Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed teh Profile directory from the Firefox root dir #68

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

MattMuffin
Copy link
Contributor

Works on MacOS 14.6.1

NB: Please make an issue prior to embarking on any significant effort towards
a pull request. This will serve as a unified place for discussion and hopefully
make sure that the change seems reasonable to merge once its implementation is
complete.

Description

MacOs stores Firefox profiles.ini under ~/Library/Application Support/Firefox and not ~/Library/Application Support/Firefox/Profiles

MacOs version: 14.6.1
Firefox Version: 129.0.1

Status

READY/IN DEVELOPMENT

Todos

  • Detect if path exists; if not, add /Profiles
  • Documentation

@n8henrie
Copy link
Owner

Interesting, thanks for the PR.

This worked before, but I'm seeing an error now, so I'm guessing FF changed? I'm on 129.

@grandchild wrote most of this code -- are you also seeing an error? We might need to do some kind of conditional check based on version (or perhaps just check both -- first the more modern location and then the legacy location).

@grandchild
Copy link
Collaborator

Ah, interesting. Will make a different PR to fix this more in-depth, if that's okay with you, @MattMuffin?

@MattMuffin
Copy link
Contributor Author

@grandchild yes that's fine, I won't hold grudges :)

@n8henrie n8henrie merged commit 0faa4ee into n8henrie:dev Oct 31, 2024
0 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants